tsteven4 [Thu, 11 Oct 2018 17:28:41 +0000 (11:28 -0600)]
correct sort filter time option to use msecs.
GPSBabel [Tue, 9 Oct 2018 05:45:25 +0000 (00:45 -0500)]
Merge pull request #255 from gpsbabel/parallel
Parallelize CLI and GUI make.
Robert Lipe [Tue, 9 Oct 2018 04:57:28 +0000 (04:57 +0000)]
Parallelize CLI and GUI make. testo and vtesto are harder.
GPSBabel [Tue, 9 Oct 2018 04:20:55 +0000 (23:20 -0500)]
Merge pull request #254 from gpsbabel/tweaks
Move more xcsv processing into QStrings. Fewer conversions
Robert Lipe [Tue, 9 Oct 2018 03:27:05 +0000 (03:27 +0000)]
Allow string to be modified during parse. Ugh.
Robert Lipe [Mon, 8 Oct 2018 23:20:45 +0000 (18:20 -0500)]
Let xcsv parser keep QStrings up for one more level.
Robert Lipe [Mon, 8 Oct 2018 23:17:34 +0000 (18:17 -0500)]
Push QStrings -> char * conversions down one more level.
GPSBabel [Mon, 8 Oct 2018 23:14:58 +0000 (18:14 -0500)]
Merge pull request #253 from gpsbabel/tweaks
Find gsed when doing a tools/docfix on a Mac populated by Homebrew: G…
Robert Lipe [Mon, 8 Oct 2018 19:21:04 +0000 (14:21 -0500)]
Find gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr/local/bin/
GPSBabel [Mon, 8 Oct 2018 19:20:31 +0000 (14:20 -0500)]
Merge pull request #252 from gpsbabel/tweaks
Find gsed when doing a tools/docfix on a Mac populated by Homebrew: GNU sed is /usr/local/bin/
GPSBabel [Sat, 6 Oct 2018 04:24:14 +0000 (23:24 -0500)]
Merge pull request #249 from codacy-badger/codacy-badge
Add a Codacy badge to README.md
GPSBabel [Fri, 14 Sep 2018 21:05:48 +0000 (16:05 -0500)]
Add codacy badges to Github README.md
The Codacy Badger [Fri, 14 Sep 2018 20:55:52 +0000 (20:55 +0000)]
Add Codacy badge
tsteven4 [Sat, 1 Sep 2018 12:52:27 +0000 (06:52 -0600)]
Merge pull request #246 from tsteven4/trackdata
introduce optional class
tsteven4 [Thu, 30 Aug 2018 16:36:07 +0000 (10:36 -0600)]
introduce optional class
for things that may or may not have a value.
demonstrate usage with computed_trkdata.
tsteven4 [Sat, 25 Aug 2018 22:37:27 +0000 (16:37 -0600)]
Merge pull request #245 from tsteven4/exif2
a few exif cleanups.
tsteven4 [Sat, 25 Aug 2018 21:17:03 +0000 (15:17 -0600)]
a few exif cleanups.
tsteven4 [Thu, 23 Aug 2018 00:22:25 +0000 (18:22 -0600)]
Merge pull request #230 from tsteven4/bng
allow unicsv bng input to use all numeric grid references.
tsteven4 [Wed, 22 Aug 2018 23:51:34 +0000 (17:51 -0600)]
tweak unicsv bng documentation thanks Hornbydd.
tsteven4 [Wed, 22 Aug 2018 21:27:44 +0000 (15:27 -0600)]
Merge pull request #238 from tsteven4/exif
update exif format replacing queues, legacy time_t, tm, localtime, gmtime with Qt classes.
enhance exif rational number approximation using continued fractions.
support uncompressed thumbnails on write.
make debug support dynamic based on debug level instead of a conditional compile.
enhance exif test for write.
tsteven4 [Wed, 22 Aug 2018 15:37:13 +0000 (09:37 -0600)]
add exif support for uncompressed thumbnails.
tsteven4 [Wed, 22 Aug 2018 00:03:43 +0000 (18:03 -0600)]
fix exif dynamic debug omissions.
tsteven4 [Tue, 21 Aug 2018 21:05:29 +0000 (15:05 -0600)]
fix exif warnings.
tsteven4 [Tue, 21 Aug 2018 18:09:00 +0000 (12:09 -0600)]
replace legacy time handling in exif.
also add support of exif OffsetTime* tags.
tsteven4 [Sun, 19 Aug 2018 22:43:51 +0000 (16:43 -0600)]
minor fixes for exif.
tsteven4 [Sun, 19 Aug 2018 22:03:50 +0000 (16:03 -0600)]
use QVariant to store exif tag data.
enhance exif debug capability.
tsteven4 [Sat, 18 Aug 2018 18:50:07 +0000 (12:50 -0600)]
use continued fractions to create TIFF RATIONAL types.
some references were regenerated as the new algorithm
can generate different values for the RATIONAL numerator
and denominator, in this case 0.0 -> 0/INT32_MAX.
tsteven4 [Thu, 16 Aug 2018 23:53:13 +0000 (17:53 -0600)]
improvements to exif format.
fix bugs with rational types including greatest common divisor.
turn off assertions for release builds in GPSBabel.pro.
clean up exif.
tsteven4 [Wed, 8 Aug 2018 14:31:19 +0000 (08:31 -0600)]
tweak endian routines for consistency. (#242)
align util routeines with prototypes using readability-inconsistent-declaration-parameter-name.
tsteven4 [Thu, 2 Aug 2018 01:21:18 +0000 (19:21 -0600)]
eliminate queues in inifile. (#239)
* eliminate queues in inifile replacing them with QHashs
* replace use of gbfile in inifile with QTextStream
Robert Lipe [Tue, 31 Jul 2018 09:08:28 +0000 (04:08 -0500)]
Final presubmit cleanups
Ship it when it’s green. (and it’s tomorrow, errr, today.)
Robert Lipe [Tue, 31 Jul 2018 05:34:44 +0000 (00:34 -0500)]
Fix leak in last cleanup.
Mixing C pointers and sane pointers is killing me…
Robert Lipe [Tue, 31 Jul 2018 05:18:11 +0000 (00:18 -0500)]
Rewrite xcsv_parse_style_buff() in a readable way
…might be more clever with a QStringRef, but this is hardly a
performance path.
Robert Lipe [Tue, 31 Jul 2018 04:42:17 +0000 (23:42 -0500)]
Degrubbify for submit
Remove “global” char*’s in body of csv format parser. Make argument
type String to allow fixing callers later. Reformat. Fix bugs of char*
and QString[] being out of sync by eliminating one source of truth.
Robert Lipe [Tue, 31 Jul 2018 00:29:14 +0000 (19:29 -0500)]
Fix crash in -^ generating doc list
vecs_t is no longer a struct of POD. It’s now a class and has to be
allocated by new. I hope to not have to rathole in vets for this change
because it’s full of scary memory management like this.
Robert Lipe [Mon, 30 Jul 2018 08:29:46 +0000 (03:29 -0500)]
Resync with work copy
Robert Lipe [Mon, 30 Jul 2018 06:09:39 +0000 (01:09 -0500)]
Merge branch 'master' into cleanups
Robert Lipe [Mon, 30 Jul 2018 06:00:17 +0000 (01:00 -0500)]
xcdv to data structures continues
Passes testo. Exposes lots of weird stuff (all marked with FIXMEs) that
are still held up with C pointer magic, but we eliminate a few hundred
cases, so I’m just looking for a test run before digging deeper.
Robert Lipe [Mon, 30 Jul 2018 01:48:54 +0000 (20:48 -0500)]
More data structure work in xcsv
Push QStringification up two levels. Keep table and callers of
substations in Qt-land to keep QHash happy and reduce copy/leak in most
cases.
tsteven4 [Mon, 23 Jul 2018 22:02:03 +0000 (16:02 -0600)]
fix codacy/cppcheck whining.
tsteven4 [Mon, 23 Jul 2018 21:06:48 +0000 (15:06 -0600)]
incorporate review suggestions and fix bugs.
correct user comment encoding based on image endianness.
fix possible tag corruption when data fits in 4 bytes depending
on image endianness and processor endianness.
Robert Lipe [Sun, 22 Jul 2018 06:41:05 +0000 (01:41 -0500)]
Allow field options in ifield, ofield
Options can make fields.size() of 4, so loosen error test for those.
Misc warning fixes.
Robert Lipe [Sun, 22 Jul 2018 06:22:39 +0000 (01:22 -0500)]
Pick up dropped file from last commit
Ooops. Add xcd.cc back to this CL.
Robert Lipe [Sun, 22 Jul 2018 05:19:50 +0000 (00:19 -0500)]
Move csv & style handlers to real C++ containers
Goal: eliminate lots of manual string bashing.
Currently waffles between the two approaches, but I wanted to get this
into GitHub for valgrind results.
tsteven4 [Fri, 20 Jul 2018 11:05:13 +0000 (05:05 -0600)]
fix new exif memory leaks.
tsteven4 [Fri, 20 Jul 2018 01:51:51 +0000 (19:51 -0600)]
fix exif test to run in any time zone.
tsteven4 [Thu, 19 Jul 2018 21:43:14 +0000 (15:43 -0600)]
replace exif format usage of queues.
tsteven4 [Mon, 16 Jul 2018 13:49:19 +0000 (07:49 -0600)]
update gpx handling of global/metadata. (#236)
* update gpx handling of global/metadata.
use qt containers instead of queue.
add support for gpx/metadata/link.
* incorporate suggestions from review.
* update notes on justification for concatenating metadata.
tsteven4 [Sun, 15 Jul 2018 00:13:53 +0000 (18:13 -0600)]
Merge pull request #234 from tsteven4/reinterp
use reinterpret_cast with queue processing
tsteven4 [Sat, 14 Jul 2018 23:01:41 +0000 (17:01 -0600)]
use reinterpret_cast with queues.
tsteven4 [Sat, 14 Jul 2018 15:06:27 +0000 (09:06 -0600)]
use reinterpret_cast with queue processing
instead of a static cast to a void pointer followed
by a static cast to a Waypoint*.
tsteven4 [Fri, 13 Jul 2018 13:11:48 +0000 (07:11 -0600)]
Merge pull request #231 from tsteven4/jeeps
obsolete jeeps/gpsproj.h.
tsteven4 [Fri, 13 Jul 2018 00:18:08 +0000 (18:18 -0600)]
clean up some Variable * is reassigned a value before the old one has been used. (#232)
one of these was actually a very old bug.
tsteven4 [Thu, 12 Jul 2018 21:46:38 +0000 (15:46 -0600)]
obsolete jeeps/gpsproj.h.
Note that jeeps/gpsproj.cc is not used.
Historically some routines have been copied from gpsproj.cc to
gpsmath.cc. When/If this is done the corresponding headers from
gpsproj.h should be copied to gpsmath.h.
tsteven4 [Thu, 12 Jul 2018 15:19:57 +0000 (09:19 -0600)]
allow unicsv bng input to use all numeric grid references.
tsteven4 [Thu, 12 Jul 2018 14:51:26 +0000 (08:51 -0600)]
const qualify some function parameters. (#229)
This is the clang-tidy check readability-non-const-parameter.
tsteven4 [Wed, 11 Jul 2018 22:56:20 +0000 (16:56 -0600)]
refactor "Declarator and assignment can be joined." (#227)
* refactor "Delarator and assignment can be joined."
Instances involving switch statements or goto statemens were skipped.
jeeps was skipped as well.
* fix pointer formatting case.
* more whitespace corrections.
tsteven4 [Tue, 10 Jul 2018 16:28:20 +0000 (10:28 -0600)]
Merge pull request #228 from tsteven4/gdb
fix irrelevant booboo in
23cb08f17.
tsteven4 [Tue, 10 Jul 2018 15:53:07 +0000 (09:53 -0600)]
fix irrelevant booboo in
23cb08f17.
This only mattered if NEW_STRINGS wasn't defined,
and it always is, except if running cppcheck.
tsteven4 [Mon, 9 Jul 2018 18:19:35 +0000 (12:19 -0600)]
Merge pull request #226 from tsteven4/resetb4read
refactor cases of "Declarator is reassigned in all paths before being read"
when the declarator and the subsequent assignment can be joined.
tsteven4 [Mon, 9 Jul 2018 17:35:53 +0000 (11:35 -0600)]
recover some lost comments.
tsteven4 [Mon, 9 Jul 2018 17:19:51 +0000 (11:19 -0600)]
refactor cases of "Declarator is reassigned in all
paths before being read"
when the declarator and the subsequent assignment can be joined.
tsteven4 [Mon, 9 Jul 2018 13:16:42 +0000 (07:16 -0600)]
Merge pull request #224 from tsteven4/unusedinit
limit scope of loop vars, prefer prefix operators.
tsteven4 [Mon, 9 Jul 2018 01:21:28 +0000 (19:21 -0600)]
use prefix increment on enums in brauniger_iq, garmin_txt, igc.
tsteven4 [Sun, 8 Jul 2018 23:29:22 +0000 (17:29 -0600)]
limit scope of index variables in for loops.
tsteven4 [Sun, 8 Jul 2018 14:42:26 +0000 (08:42 -0600)]
Merge pull request #223 from tsteven4/nullptr
clang-tidy readability-delete-null-pointer
tsteven4 [Sun, 8 Jul 2018 13:53:06 +0000 (07:53 -0600)]
clang-tidy readability-delete-null-pointer
formatted by hand.
tsteven4 [Sat, 7 Jul 2018 13:34:23 +0000 (07:34 -0600)]
Merge pull request #222 from tsteven4/cmake2
catch CMakeLists up.
tsteven4 [Sat, 7 Jul 2018 12:51:37 +0000 (06:51 -0600)]
catch CMakeLists up.
Robert Lipe [Sat, 7 Jul 2018 06:59:40 +0000 (01:59 -0500)]
Merge pull request #221 from gpsbabel/cleanups
Cleanups: remove jeeps gpsinput.*
Robert Lipe [Sat, 7 Jul 2018 06:03:30 +0000 (01:03 -0500)]
Remove gpsinput.{cc,h}
Remove unused Jeeps file handling old Jeeps Almanac files and other
esoterica uninteresting to us.
Robert Lipe [Sat, 7 Jul 2018 05:37:36 +0000 (00:37 -0500)]
Merge pull request #137 from viettaml/master
Fix redundant file rename on Windows
Robert Lipe [Sat, 7 Jul 2018 05:30:10 +0000 (00:30 -0500)]
Merge pull request #218 from gpsbabel/cleanups
Cleanups
Robert Lipe [Sat, 7 Jul 2018 04:51:44 +0000 (23:51 -0500)]
Remove more C casts
Remove some senseless casts to ints, explicitly avoid const-ified queue
iterators.
Robert Lipe [Sat, 7 Jul 2018 04:20:18 +0000 (23:20 -0500)]
More queue casting
This doesn’t _really_ help improve the code; this is to get a passing
presubmit from codify.
GPSBabel [Fri, 6 Jul 2018 00:00:05 +0000 (19:00 -0500)]
Merge pull request #220 from tsteven4/cmake
Add CMakeLists.txt.
tsteven4 [Thu, 5 Jul 2018 22:11:58 +0000 (16:11 -0600)]
Add CMakeLists.txt.
This is experimental at this stage.
Robert Lipe [Thu, 5 Jul 2018 05:40:24 +0000 (00:40 -0500)]
downcast queue_elem to void then up to Waypoint
(yes, this is distasteful)
Robert Lipe [Thu, 5 Jul 2018 03:53:22 +0000 (22:53 -0500)]
Fix delete/xfree mismatch in xmltag copy
Other misc minor changes tweaks identified by codacy during last commit.
Robert Lipe [Wed, 4 Jul 2018 22:34:12 +0000 (17:34 -0500)]
Rollback erroneously committed files
git rm -r build-app-Desktop_Qt_5_9_5_clang_64bit-Debug/
(Thanx, tsteven4!)
tsteven4 [Wed, 4 Jul 2018 21:00:25 +0000 (15:00 -0600)]
Merge pull request #219 from tsteven4/clean888
miscellaneous cleanups & bug fixes.
tsteven4 [Wed, 4 Jul 2018 20:20:00 +0000 (14:20 -0600)]
miscellaneous cleanups & bug fixes.
easygps.cc: bugfix - clang-tidy check misc-sizeof-expression
garmin_fs.cc: warning cleanup - gcc warning: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 3 [-Wformat-truncation=]
jtr.cc: warning cleanup - gcc warning: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Wformat-truncation=]
jtr.cc: bugfix - the jtr writter could incorrecly print the msec portion of the creationtime by dropping the most significant digit when it was zero.
mapsource.cc: warning cleanup - binary operator acts on identical operands
random.cc: bugfix - fractional seconds were always zero.
tpo.cc: warning cleanup - gcc warning: argument 2 null where non-null expected [-Wnonnull]
xmlgeneric.cc: warning cleanup - Declarator is never used
Robert Lipe [Wed, 4 Jul 2018 20:05:13 +0000 (15:05 -0500)]
Typo fix
waypoint -> Waypoint in last commit wasn’t saved from editor buffer
Robert Lipe [Wed, 4 Jul 2018 20:00:52 +0000 (15:00 -0500)]
Revert stupid commits
Grrr. Github desktop works exactly like git command line doesn’t for
uncommitted files. :-/
Robert Lipe [Wed, 4 Jul 2018 19:51:37 +0000 (14:51 -0500)]
Reduce scope of a ton of variables, misc cleanups
Codacy-inspired cleanups. Makes code look more C++-looking in many
places.
tsteven4 [Tue, 3 Jul 2018 22:58:17 +0000 (16:58 -0600)]
eliminate some redundant redclarations. (#217)
tsteven4 [Tue, 3 Jul 2018 20:54:00 +0000 (14:54 -0600)]
eliminate some uneccessary passing by value in favor of pass by const reference. (#216)
tsteven4 [Tue, 3 Jul 2018 17:40:57 +0000 (11:40 -0600)]
cleanup filter class issues. (#215)
tsteven4 [Sun, 1 Jul 2018 20:37:35 +0000 (14:37 -0600)]
Merge pull request #213 from tsteven4/constcast
use const_cast to cast away const, and don't cast away const when unnecessary
tsteven4 [Sun, 1 Jul 2018 19:23:38 +0000 (13:23 -0600)]
a few more const_cast eliminations.
tsteven4 [Sun, 1 Jul 2018 18:36:47 +0000 (12:36 -0600)]
preserve const in garmin_txt.
tsteven4 [Sun, 1 Jul 2018 15:26:10 +0000 (09:26 -0600)]
remove more unnecessary const_casting.
tsteven4 [Sun, 1 Jul 2018 14:45:33 +0000 (08:45 -0600)]
get rid of more unneeded const_cast.
tsteven4 [Sun, 1 Jul 2018 12:36:11 +0000 (06:36 -0600)]
get MSVC happy with util const_cast changes.
tsteven4 [Sun, 1 Jul 2018 12:26:42 +0000 (06:26 -0600)]
remove unnecesary const_cast in util.cc.
tsteven4 [Sat, 30 Jun 2018 21:17:12 +0000 (15:17 -0600)]
eliminate uneccesary const_cast in osm format.
tsteven4 [Sat, 30 Jun 2018 21:10:10 +0000 (15:10 -0600)]
Merge remote-tracking branch 'origin/master' into constcast
tsteven4 [Sat, 30 Jun 2018 21:05:55 +0000 (15:05 -0600)]
use member brace initializes and default constructors. (#214)
tsteven4 [Sat, 30 Jun 2018 14:19:23 +0000 (08:19 -0600)]
remove more unnecessary casting away of const.
tsteven4 [Sat, 30 Jun 2018 13:34:15 +0000 (07:34 -0600)]
remove unnecessary casting away of const.